Clone container contents instead of container itself #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the line wrap.html(container.html()); was changed to wrap.html(container.clone(true)); it fixed the problem of JS events getting lost, but now instead of copying the container content it makes a duplicate of the container itself. This duplication leads to problems with the default videoBG usage actually creating another body element within the main body element, which in turn causes incompatibilities with other plugins and code that perform operations on the “body” element. This commit still uses the jQuery clone() method to maintain JS events, but instead of cloning the container, it clones the container’s children (i.e. its content) into the videoBG wrapper.
|
I believe this one should be merged, any thoughts @sydlawrence ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the line
wrap.html(container.html());was changed towrap.html(container.clone(true));it fixed the problem of JS events getting lost, but now instead of copying the container content, it makes a duplicate of the container itself. This duplication leads to problems with the default videoBG usage, as it creates another<body>element within the main<body>element, which in turn causes incompatibilities with other plugins and code that perform operations on$(“body”).This commit still uses the jQuery clone() method to maintain JS events, but instead of cloning the container, it clones the container’s children (i.e. its content) into the videoBG wrapper.