Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, commonjs projects will be hit with the following error:
By replacing the export statement with
module.export
for the commonjsnode.js
fiel, I am quite positive that this PR should solve that issue.I tested this on Node
v16.16.0
&v18.14.2
with acommonjs
and amodule
project and lastly with a nodejs (index.js) script and a typescript (index.ts) script viats-node
. All combinations of what I mentioned here.Linked Issues
--
Additional context
I need this change somewhat urgently for a library that I'm maintaining as two people are stuck on this issue as of now. I made the change from
isomorphic-ws
as it's barely maintained and had caused issues for importing into certain environments. Ironically, this library is now also causing issues though I can see how this library is better thanisomorphic-ws
馃槢