Runtimes: adjust global flags in preparation for extending the Core project #78504
+29
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits up the flags and re-orders some of the condition for the application. Because the flags are now categorised by the language promote the other half of the condition to the front.
These set of Swift flags are applied to all runtime libraries that are built. Hoist them to the top-level to spell them once and to keep all the libraries in sync.
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
etcwilde
approved these changes
Jan 8, 2025
edymtt
approved these changes
Jan 9, 2025
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes prepares us to add additional installed libraries into the project by extracting the Swift flags that apply universally to the libraries.