[cmake] Hook up SWIFT_STDLIB_HAS_FILESYSTEM macro
#78453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
compnerd,
edymtt,
al45tair and
justice-adams-apple
|
@swift-ci please test |
compnerd
reviewed
Jan 7, 2025
This hooks up the SWIFT_STDLIB_HAS_FILESYSTEM, which then requires setting SWIFT_ARCH and SWIFT_LIB_SUBDIR macros for the backtracer. Note: `FILESYSTEM` in this case does not refer to the C++ filesystem header, but whether the platform you're building for has a filesystem.
Updating the Apple cmake caches to enable the filesystem support, setting the appropriate architecture and platform subdirectories.
etcwilde
force-pushed
the
ewilde/stdlib-rebuild-has-filesystem
branch
from
afc7495 to
aed70b3
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Jan 7, 2025
edymtt
approved these changes
Jan 7, 2025
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch hooks up the
SWIFT_STDLIB_HAS_FILESYSTEMmacro define in the new swiftCore build system, while also settingSWIFT_LIB_SUBDIRandSWIFT_ARCH, which is required as part of finding the backtracer in theswiftRuntimetarget.The new build-system flags to set this up are
rdar://142440689