Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: update short name for Android #78449

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jan 6, 2025

Update the shortnames used for the android SDK builds to allow building the SDK properly.

Update the shortnames used for the android SDK builds to allow building
the SDK properly.
@compnerd
Copy link
Member Author

compnerd commented Jan 6, 2025

CC: @andrurogerz @hjyamauchi

@compnerd
Copy link
Member Author

compnerd commented Jan 6, 2025

@swift-ci please smoke test

@andrurogerz
Copy link
Contributor

I think this exact change worked for me a while back, but I wasn't sure it was the right fix. If it is building properly for you locally, lgtm.

@compnerd
Copy link
Member Author

compnerd commented Jan 6, 2025

It was working locally and worked on swift.org CI as well. I think that this is likely the right thing to do. I inspected the other call use sites of this and didn't see any reason that this should impact anything else.

@compnerd
Copy link
Member Author

compnerd commented Jan 6, 2025

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2025

@swift-ci please smoke test Linux platform

@compnerd compnerd merged commit 8f6ad4c into swiftlang:main Jan 7, 2025
4 of 5 checks passed
@compnerd compnerd deleted the shortage branch January 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants