[embedded] Skip C++ stdlib for unicode stubs #76761
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stdint.h` should be picked up from `clang/lib/Headers`, but is instead being picked up by the system libc++. There's no C++ stdlib being used here, so just exclude it. Resolves rdar://134584685.
|
@swift-ci please test |
|
Nice, I didn't think of that. If this actually resolves the issue, LGTM! |
kubamracek
approved these changes
Sep 28, 2024
Did locally, but we'll see :) |
|
@swift-ci build toolchain Ubuntu 22.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdint.hshould be picked up fromclang/lib/Headers, but is instead being picked up by the system libc++. There's no C++ stdlib being used here, so just exclude it.Resolves rdar://134584685.