Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upcoming feature flag annotations #2370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dempseyatgithub
Copy link
Contributor

Based on conversations with the LSG, this PR adds an annotation to each upcoming feature flag that is enabled by default in an announced Swift language mode.

There is no annotation for flags enabled by default in a future, unannounced language mode.

For example, the ExistentialAny flag introduced with SE-0335 is not enabled by default in Swift 6 language mode and therefore does not have an added annotation (or appear in this PR).

Add an annotation to each upcoming feature flag that is enabled by default
in an announced Swift language mode.

At present that is only Swift 6 language mode.

Note the `ExistentialAny` flag is not enabled by default
in Swift 6 language mode and thereforedoes not have an
added annotation.
Copy link
Contributor

@benrimmington benrimmington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other proposals might also need updating, with the following upcoming features:

UPCOMING_FEATURE(StrictConcurrency, 0337, 6)
UPCOMING_FEATURE(ImplicitOpenExistentials, 352, 6)
UPCOMING_FEATURE(GlobalConcurrency, 412, 6)
UPCOMING_FEATURE(RegionBasedIsolation, 414, 6)

proposals/0413-typed-throws.md Show resolved Hide resolved
proposals/0423-dynamic-actor-isolation.md Show resolved Hide resolved
@dempseyatgithub

This comment was marked as outdated.

@dempseyatgithub
Copy link
Contributor Author

Other proposals might also need updating, with the following upcoming features:

UPCOMING_FEATURE(StrictConcurrency, 0337, 6)
UPCOMING_FEATURE(ImplicitOpenExistentials, 352, 6)
UPCOMING_FEATURE(GlobalConcurrency, 412, 6)
UPCOMING_FEATURE(RegionBasedIsolation, 414, 6)

Since each of these may have a reason why the feature flag is not listed in the proposal, I've opened a PR for each and CC'd the authors/review manager for the proposal to figure out what should be done for each:

#2381
#2382
#2383
#2384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial change to an existing document LSG Contains topics under the domain of the Language Steering Group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants