Tests: repair the test suite on Windows #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
| @@ -3054,10 +3060,10 @@ final class SwiftDriverTests: XCTestCase { | |||
| XCTAssertEqual(emitModuleJob.outputs[0].file, try toPath("Test.swiftmodule")) | |||
| XCTAssertEqual(emitModuleJob.outputs[1].file, try toPath("Test.swiftdoc")) | |||
| XCTAssertEqual(emitModuleJob.outputs[2].file, try toPath("Test.swiftsourceinfo")) | |||
| XCTAssertEqual(emitModuleJob.outputs[3].file, try VirtualPath(path: "./Test.swiftinterface")) | |||
| XCTAssertEqual(emitModuleJob.outputs[3].file, try VirtualPath.relative(.init("Test.swiftinterface"))) | |||
There was a problem hiding this comment.
This seems to failed the test. I forgot why those two outputs behaves differently from other output kinds, maybe they should behave the same.
There was a problem hiding this comment.
Yeah, I think that they should behave the same. Also interesting is that it passed on Windows and Linux, but failed only on macOS?
|
@swift-ci please test macOS platform |
|
@swift-ci please test macOS platform |
With this set of changes, we are now down to 1 failure on the SwiftDriverTests on Windows. While we are not near the original state of tests on Windows (the full test suite used to pass), this is a step in the right direction.
Remove the printing of the generated command line. If there are cases where we need to diagnose failures in CI, we should prefer to build helpers that will show the actual and expected values to enable us to triage issues more readily.
Use the `assertDriverDiagnostics` helper to ensure that all the emitted diagnostics are verified. Remove the debug printing and output to the logs. This is no longer necessary as we will verify that any additional diagnostics emitted are checked and the helper will render the missed or non-matching diagnostics allowing easy triaging of the failures in CI.
This repairs the ExplicitModuleBuildTests test suite on Windows. The input adjustment is required to match the paths after processing.
These changes repair the test failure son Windows, which is required to bring the swift driver test suite back to fully passing on Windows as it was previously.
|
@swift-ci please test |
|
@artemcm this actually happens to correct a behavioral issue that was overlooked due to a test mistake. |
|
@swift-ci please test Windows platform |
compnerd
changed the title
artemcm
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this set of changes, we now can run the test suite on Windows to completion, restoring the state to where it was originally.