Change the default timeout to 5 mins #65
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
qalandarov
changed the title
dimitribouniol
approved these changes
May 9, 2024
| /// - attestation: The Relying Party's preference regarding attestation. Defaults to `.none`. | ||
| /// - publicKeyCredentialParameters: A list of public key algorithms the Relying Party chooses to restrict | ||
| /// support to. Defaults to all supported algorithms. | ||
| /// - Returns: Registration options ready for the browser. | ||
| public func beginRegistration( | ||
| user: PublicKeyCredentialUserEntity, | ||
| timeout: Duration? = .seconds(3600), | ||
| timeout: Duration? = .milliseconds(300000), |
There was a problem hiding this comment.
Now if only we could just specify .minutes(5) 😛
There was a problem hiding this comment.
Upon further reflection (and reading the original reason why .minutes() is not a thing), I think it would be best to specify this as an expression:
Suggested change
| timeout: Duration? = .milliseconds(300000), | |
| timeout: Duration? = .seconds(5*60), |
I'll leave the call to you though, as there's nothing explicitly wrong with how it is now, just potentially clearer to whoever is reading the code and not the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the code said that the default was 60 seconds, but the code was set 60 mins.
And @dimitribouniol pointed out that the actual default based on the spec was 5 mins :)