Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): Add versioned wrapper struct #7382

Merged
merged 5 commits into from
May 15, 2023

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented May 12, 2023

Description:

Second attempt to #5060, enabling versioned wrapper struct against serializable values for the plugin.

BREAKING CHANGE:

This PR is clear breaking changes for the plugin, requires bump up swc_core, @swc/core and relavant plugins (and next-swc).

@kwonoj kwonoj force-pushed the feat-versioned-struct branch 2 times, most recently from 14eba57 to 9a57c24 Compare May 12, 2023 05:56
@kwonoj kwonoj marked this pull request as draft May 12, 2023 07:50
@kwonoj kwonoj force-pushed the feat-versioned-struct branch 3 times, most recently from 0576acb to 9282a95 Compare May 12, 2023 22:00
@kwonoj kwonoj marked this pull request as ready for review May 13, 2023 00:10
@kdy1 kdy1 changed the title feat(plugin: add versioned wrapper struct feat(plugin): Add versioned wrapper struct May 14, 2023
@kdy1 kdy1 added this to the Planned milestone May 14, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll not mark this as a breaking change to avoid updating swc_core again needlessly, where it's not necessary because we didn't published @swc/core with [email protected]


swc-bump:

  • swc_common
  • swc_plugin_proxy
  • swc_plugin_runner

@kdy1 kdy1 enabled auto-merge (squash) May 15, 2023 02:22
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 self-assigned this May 15, 2023
@kdy1 kdy1 merged commit bba1fad into swc-project:main May 15, 2023
127 checks passed
@kwonoj kwonoj deleted the feat-versioned-struct branch May 15, 2023 03:32
@kdy1 kdy1 modified the milestones: Planned, v1.3.58 May 15, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants