Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update geeksay.js #443

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update geeksay.js #443

wants to merge 5 commits into from

Conversation

psyop-21
Copy link

@psyop-21 psyop-21 commented Oct 13, 2022 •
edited

wrote a quote for the project :)

dk3775
dk3775 requested changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@dk3775 dk3775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is improper syntax it will lead to error.

@psyop-21 psyop-21 requested a review from dk3775 October 14, 2022 16:15
psyop-21
psyop-21 commented Oct 14, 2022
View reviewed changes
Copy link
Author

@psyop-21 psyop-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for letting me know @dk3775 where I had a syntax error. I've made some improvements, please let me know if they are acceptable or not.

@dk3775
Copy link
Collaborator

dk3775 commented Oct 17, 2022

Hey @rishi-kai21,
Check here
image
You are missing "," in three lines.

Also, your added quote translation is invalid.

@psyop-21
Copy link
Author

Hey @rishi-kai21, Check here image You are missing "," in three lines.

Also, your added quote translation is invalid.

please review the changes I've made . I apologise for taking your time.

psyop-21
psyop-21 commented Oct 18, 2022
View reviewed changes
Copy link
Author

@psyop-21 psyop-21 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this is fine now :)

@dk3775
Copy link
Collaborator

dk3775 commented Oct 19, 2022

hey @rishi-kai21, your word translations are good but the quote translation is not as per geeksay.xyz .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dk3775 dk3775 Awaiting requested review from dk3775

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@psyop-21 @dk3775