Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed lodash.pick #2235

Merged
merged 2 commits into from
Sep 13, 2021
Merged

removed lodash.pick #2235

merged 2 commits into from
Sep 13, 2021

Conversation

jimmywarting
Copy link
Contributor

Description

I removed and replaced lodash.pick with object destructuring

Motivation and Context

part of #2187

How Has This Been Tested?

executed test

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

char0n
char0n approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@char0n
Copy link
Member

char0n commented Sep 13, 2021

@jimmywarting can you please fix the styling issues using lint:fix npm script?

@char0n char0n merged commit af2b86c into swagger-api:master Sep 13, 2021
@swagger-bot
Copy link
Contributor

🎉 This PR is included in version 3.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmywarting @char0n @swagger-bot