implement clone derive macro for Sivx client

[imabdulbasit]

Motivation

Configuration struct derives clone macro so Sivx struct can also derive it. This would be helpful to clone Sivx client when sharing it between threads without wrapping it in Arc.

Solution

Add Clone derive macro

[tasn]

I'm not against cloning it per-se, but it feels wasteful to clone it and all of the inner structure for it. I almost feel like if you want to do it, we should at least have the inner object wrapped in an Arc, no?

[imabdulbasit]

I'm not against cloning it per-se, but it feels wasteful to clone it and all of the inner structure for it. I almost feel like if you want to do it, we should at least have the inner object wrapped in an Arc, no?

Inner structure already has Clone implemented. Svix client uses reqwest which implements Arc internally :)

[tasn]

There's a Configuration structure, no? It probably includes multiple things in it.

[imabdulbasit]

There's a Configuration structure, no? It probably includes multiple things in it.

Yes but Configuration structure already implements Clone (https://docs.rs/webhooks/0.0.1/src/webhooks/apis/configuration.rs.html#14) so Svix struct can also implement clone

[tasn]

Yeah, but that's what I'm saying, it ends up cloning the whole Configuration structure...

Anyhow, I can go either way. @svix-gabriel, do you have any thoughts on this?

[svix-gabriel]

I definitely see the value in implementing Clone, but I agree with the suggestion that this should wrap the Configuration struct in an Arc<...> internally. Clone will be more performant if it's just incrementing a reference count, rather than copying all of the underlying strings and other configuration data.