Enable requeue_on_nack for rabbitmq task queue backend #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
svix-jplatte
force-pushed
the
jplatte/rabbitmq-requeue-on-nack
branch
from
c17608e
to
db10ea1
Compare
svix-lucho
approved these changes
Apr 30, 2024
|
Not merging yet because I'm not entirely certain about my understanding of intended default, should have made this a draft until it's confirmed I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I asked about this flag when porting things to omniqueue but failed to actually follow up on the feedback. Apparently
trueis the intended default, though this is not documented anywhere.Solution
Use the intended default.