fix: repair each block length even without an else #12098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte 5 rewrite
Fixes #12095
I don't know if it's the correct approach but tests are all greens and it fixes the problem. As i've explained in the comments the error was happening because if the length on the server was 0 hydration was only set to false if an
{:else}
branch was specified by the user.Initially i thought of always add the
HIDRATION_END_ELSE
marker if the array length was 0 on the server (even if the fallback was not provided by the user) but this would've add an if for every each. So i tried to infer if the length was 0 in another way and i come up with the idea of checking the length of hydrate_nodes but to be fair i don't know if this is correct so i would appreciate some input.Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint