Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update societies.json - added Berlin meeting #643

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

nika-d
Copy link
Contributor

@nika-d nika-d commented Jul 10, 2024

🎯 Changes

✅ Checklist

  • I have given my PR a descriptive title
  • I have run pnpm run lint locally on my changes

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sveltesociety-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 6:55pm

Copy link

vercel bot commented Jul 10, 2024

@nika-d is attempting to deploy a commit to the Svelte Society Team on Vercel.

A member of the Team first needs to authorize it.

@nika-d
Copy link
Contributor Author

nika-d commented Jul 10, 2024

pnpm run lint failed first time:

~/Desktop/temp/sveltesociety.dev$ pnpm run lint

> sveltesociety.dev@ lint /Users/nikadomanska/Desktop/temp/sveltesociety.dev
> prettier --check '**/*' --ignore-unknown && eslint . && node scripts/validateData.js

Checking formatting...
All matched files use Prettier code style!
file:///Users/nikadomanska/Desktop/temp/sveltesociety.dev/scripts/validateData.js:4
import packages from '../src/routes/packages/packages.json' assert { type: 'json' };
                                                            ^^^^^^

SyntaxError: Unexpected identifier 'assert'
    at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:164:18)
    at callTranslator (node:internal/modules/esm/loader:429:14)
    at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:435:30)
    at async ModuleJob._link (node:internal/modules/esm/module_job:106:19)

Node.js v22.3.0
 ELIFECYCLE  Command failed with exit code 1.

changing assert->with in validateData.js helps, cause of my node version.

~/Desktop/temp/sveltesociety.dev$ pnpm run lint

> sveltesociety.dev@ lint /Users/nikadomanska/Desktop/temp/sveltesociety.dev
> prettier --check '**/*' --ignore-unknown && eslint . && node scripts/validateData.js

Checking formatting...
All matched files use Prettier code style!
(node:97016) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Validated packages.json
Validated templates.json

But it was not my intention to update scripts, thats why I did not push that change.

If I should push it, please let me know!

Kind regards,
Nika

@MacFJA
Copy link
Collaborator

MacFJA commented Jul 10, 2024

The url seem like a one time event, and not a recurring event.

Do you intent to update the link when the event is past or when a new event is plan ?

@nika-d
Copy link
Contributor Author

nika-d commented Jul 12, 2024

The url seem like a one time event, and not a recurring event.

Do you intent to update the link when the event is past or when a new event is plan ?

Yes, definitely. We are building up our infrastructure, and probably luma structure will change. Currently, we have in mind an own luma-site for Svelte Berlin. This still is to be discussed with other Charité-IT communities, that are still in planning phase.

@MacFJA
Copy link
Collaborator

MacFJA commented Jul 12, 2024

I will merge it, but it will be preferable if the url is fixed so you don't have to regularly create a new PR to have an up-to-date info, it will be one less things to remember to update.

@MacFJA MacFJA merged commit 272bd43 into svelte-society:main Jul 12, 2024
3 of 4 checks passed
@nika-d
Copy link
Contributor Author

nika-d commented Jul 15, 2024

I will merge it, but it will be preferable if the url is fixed so you don't have to regularly create a new PR to have an up-to-date info, it will be one less things to remember to update.

Yes, you are right! We will make one fixed url. Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants