Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added preprocessor "svelte-remove-attributes" #629

Merged
merged 4 commits into from
Jun 16, 2024
Merged

added preprocessor "svelte-remove-attributes" #629

merged 4 commits into from
Jun 16, 2024

Conversation

jacobbogers
Copy link

@jacobbogers jacobbogers commented Jun 14, 2024

preprocessor to remove attributes (like data-testid from production builds)

🎯 Change

added entry for a preprocessor

βœ… Checklist

  • I have given my PR a descriptive title
  • I have run pnpm run lint locally on my changes

preprocessor added to remove attributes from final builds
Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
sveltesociety-dev βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 16, 2024 2:05am
sveltesociety-dev-preview βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 16, 2024 2:05am

Copy link
Collaborator

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jacobbogers , you need to fix formatting, and the npm field should be the package name rather than a URL.

@jacobbogers
Copy link
Author

Hi @jacobbogers , you need to fix formatting, and the npm field should be the package name rather than a URL.

I have corrected, it is not an url but actual package name

Copy link
Collaborator

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing linting, you need to fix the prettier issues.

@jacobbogers
Copy link
Author

pnpm does not work for me, I am running prettier directly with --write, it did produce changes in package.json, so hope this works

@jacobbogers
Copy link
Author

image

@jacobbogers
Copy link
Author

"lint": "prettier --check **/* --ignore-unknown && eslint . && node scripts/validateData.js",

I am on windows, (11) remove the ' around the **/* and it will work for me, does it work on linux/mac without ' ?

@lachlancollins lachlancollins merged commit c8881e6 into svelte-society:main Jun 16, 2024
4 checks passed
@jacobbogers jacobbogers deleted the patch-1 branch June 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants