Add CaptainCodeman components / packages #440
Conversation
✅ Deploy Preview for sveltesociety-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| "animations", | ||
| "typescript" | ||
| ], | ||
| "stars": 35 |
There was a problem hiding this comment.
The stars field is not used anymore in this file.
The count should be provided here: src/lib/stars.json
(This comment is applicable for all components in this PR)
| "stars": 35 |
CaptainCodeman
force-pushed
the
captaincodeman
branch
from
c7d51f6
to
d721019
Compare
|
Updated to match latest format |
| { | ||
| "title": "svelte-theme-select", | ||
| "url": "https://captaincodeman.github.io/svelte-theme-select/", | ||
| "repository": "https://github.com/captaincodeman/svelte-theme-select", |
There was a problem hiding this comment.
this one has less than 15 stars, so perhaps we should hold off on it #442
| { | ||
| "title": "svelte-deep-zoom", | ||
| "url": "https://captaincodeman.github.io/svelte-deep-zoom", | ||
| "repository": "https://github.com/captaincodeman/svelte-deep-zoom", |
There was a problem hiding this comment.
this URL gives me a 404
| { | ||
| "title": "svelte-pan-zoom", | ||
| "url": "https://captaincodeman.github.io/svelte-pan-zoom/", | ||
| "repository": "https://github.com/captaincodeman/svelte-pan-zoom", |
There was a problem hiding this comment.
this one has less than 15 stars, so perhaps we should hold off on it #442
| { | ||
| "title": "svelte-resize-observer-action", | ||
| "url": "https://captaincodeman.github.io/svelte-resize-observer-action/", | ||
| "repository": "https://github.com/captaincodeman/svelte-resize-observer-action", |
There was a problem hiding this comment.
this one has less than 15 stars, so perhaps we should hold off on it #442
| { | ||
| "title": "svelte-disable-preload", | ||
| "url": "https://github.com/captaincodeman/svelte-disable-preload", | ||
| "repository": "https://github.com/captaincodeman/svelte-disable-preload", |
There was a problem hiding this comment.
this one has less than 15 stars, so perhaps we should hold off on it #442
| { | ||
| "title": "svelte-kit-bot-block", | ||
| "url": "https://github.com/captaincodeman/svelte-kit-bot-block", | ||
| "repository": "https://github.com/captaincodeman/svelte-kit-bot-block", |
There was a problem hiding this comment.
this one has less than 15 stars, so perhaps we should hold off on it #442
| { | ||
| "title": "svelte-intersection-observer-action", | ||
| "url": "https://captaincodeman.github.io/svelte-intersection-observer-action/", | ||
| "repository": "https://github.com/captaincodeman/svelte-intersection-observer-action", |
There was a problem hiding this comment.
this one has less than 15 stars, so perhaps we should hold off on it #442
|
There are 41 existing entries with less that 15 stars |
Right. If you look at the PR I linked you'll see I've proposed to remove those: #442. Is there a reason you closed this PR? I think it'd be nice to get your packages listed |
Yes, after I submitted and then updated the PR, which meant a lot of what I'd done was a waste of time.
If I knew about the limit in advance, I wouldn't have bothered with the PR. Personally, I think a star-limit is arbitrary and misguided. It's a dubious metric for quality when the numbers are small and doesn't account for there being a difference between a 3-month old project with 14 stars and a 3-year old project with 16 stars (a little like comparing product ratings - "one 5 star review" vs "1,000+ with 4.5 average" are different signals, and just showing "5 star rated products" would be a mistake). If anything, stars measures age, marketing, and promotion as much as anything else. IMO you're solving the wrong problem. The issue is really that the submission process is too awkward and time-consuming for both the submitter and the reviewer. Simply excluding many components to cut down on the volume makes the site of questionable value. |
Yeah, sorry about that. You caught us in the middle of a proposed transition. The PR would add an update to document the restriction so that folks would learn about it upfront. I'm not 100% sure we'll do it yet, but wanted to flag it in case
Yeah, agreed it's of somewhat limited value. It's really meant to be just a basic filter
Good point! I do think that surfacing project age and last updates would be helpful as well
Yes, that's definitely the larger issue. Though if we make it even easier to submit maybe we'll get more throwaway projects. But I suppose we can hold off for now
It's a pretty small fraction of components that would be excluded. But anyway, I think you've convinced me that maybe we should focus on making the site backed by a database instead of managing things through PRs, so I'll go ahead and close my PR. Want to reopen this one? I think we could merge it basically as you had it |
No description provided.