feat(process-exporter): Add process-exporter to dev and metal #1840
Conversation
process-exporter is a useful tool for baremetal validation. It can be used for process to process performance metric comparison like cpu time. Signed-off-by: Kaiyi <[email protected]>
Signed-off-by: Kaiyi <[email protected]>
|
From testing, it appears fixing the remaining yamllint errors will not impact the process-exporter service, but I followed exactly what https://github.com/ncabatoff/process-exporter does and it violates the yamllint rules. |
manifests/compose/dev/compose.yaml
Outdated
| ports: | ||
| - 9256:9256 | ||
| command: | ||
| - '--procfs=/host/proc' |
manifests/compose/dev/compose.yaml
Outdated
| - 9256:9256 | ||
| command: | ||
| - '--procfs=/host/proc' | ||
| - '--config.path=/config/process-exporter.yaml' |
| process_names: | ||
| - name: "{{.PID}}" | ||
| cmdline: | ||
| - '.+' |
There was a problem hiding this comment.
we can omit the yaml rule here:
cmdline:
- ".+" # yamllint disable-line rule:quoted-strings
There was a problem hiding this comment.
@KaiyiLiu1234 Can you add this as well ⬆️
| process_names: | ||
| - name: "{{.PID}}" | ||
| cmdline: | ||
| - '.+' |
There was a problem hiding this comment.
same here
cmdline:
- ".+" # yamllint disable-line rule:quoted-strings
| ports: | ||
| - 9256:9256 | ||
| command: | ||
| - '--procfs=/host/proc' |
Cleaned process exporter yaml files like removing unnecessary quotes. Signed-off-by: Kaiyi <[email protected]>
|
@vprashar2929 all addressed |
Signed-off-by: Kaiyi <[email protected]>
|
@KaiyiLiu1234 Can you fix the commit message Also looks like there is one more yamllint fix required. Can you run |
process-exporter is a useful tool for baremetal validation. It can be used for process to process performance metric comparison like cpu time.