feat: 포인트 API 구현 #29 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinhyeokFang
requested changes
Jan 21, 2024
mingmingmon
approved these changes
Jan 21, 2024
반영했습니다! |
JinhyeokFang
requested changes
Jan 23, 2024
|
|
||
| @RequiredArgsConstructor | ||
| @Service | ||
| public class StatementService { | ||
| private StatementRepository statementRepository; | ||
|
|
||
| public Statement createStatement(Member member, StatementServiceDTO.CreateStatementDTO dto) { | ||
| public Optional<Statement> createStatement(Member member, StatementServiceDTO.CreateStatementDTO dto) { |
There was a problem hiding this comment.
금액이 부족할 땐 null을 반환하지 말고 Exception을 throw해주세요!
| @@ -28,7 +28,7 @@ public Statement getStatement(Long statementId) { | |||
| return statementRepository.findByStatementId(statementId).get(); | |||
| } | |||
|
|
|||
| public Long getTotalAmountOfMember(Member member) { | |||
| public Long getTotalAmount(Member member) { | |||
| return statementRepository.findTotalAmountByMember(member); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
메서드 이름 수정은 코드 결과의 변화가 없기 때문에 깃 메시지 작성 시 fix 키워드가 아닌 refactor 키워드를 사용해주셔야 합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller 단에서는 다음과 같은 API를 구현했습니다
포인트 내역 추가생각해보니 클라이언트 쪽에서 포인트 내역을 추가할 일이 없어서 삭제했습니다Service 단에서는 다음과 같은 기능을 구현했습니다.
포인트 사용 및 적립의 경우, 포인트 내역 추가를 통해 구현이 될 거 같아서 별도로 만들지 않았습니다