Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on undefined field #3872

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

RaphaelDarley
Copy link
Contributor

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

When adding data into a schemaful table any undefined fields are currently dropped silently, I don't think data should ever be dropped silently.

What does this change do?

Error when a query attempts to write to undefined fields, which will be dropped.

What is your testing strategy?

tests wip

Is this related to any issues?

supercedes #3250

Does this change need documentation?

If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.

Have you read the Contributing Guidelines?

@RaphaelDarley RaphaelDarley mentioned this pull request Apr 14, 2024
2 tasks
@RaphaelDarley RaphaelDarley added this to the v2.0.0 milestone Apr 14, 2024
@RaphaelDarley RaphaelDarley marked this pull request as ready for review April 15, 2024 09:04
@RaphaelDarley RaphaelDarley requested a review from a team April 15, 2024 09:04
@RaphaelDarley RaphaelDarley requested a review from a team as a code owner April 15, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant