Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were failing time to time for me saying this:
The paniic points to https://github.com/surrealdb/surrealdb.go/blob/main/pkg/gorilla/gorilla.go#L205, and I see
ws.logger
beingnil
when the panic happens.We should make the logger non-nil, or make the
ws.read
goroutine wait until the logger is initialized. Otherwise, every timews.read
gets an error from the connection (e.g. the connection is closed?), AND the logger is nil (which is always the case for our no-optgorilla
ws impl in the tests), the panic happens.That's said, let's always initialize the logger for now.
We may make the logger getting lazily initialized on demand, but I think that's not a priority for now :)