Handle RPC errors #168
Merged
Handle RPC errors #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query fails, such as invalid syntax, an RPC error is returned. However, at the moment this is only logged to the terminal rather than returned as an error meaning there is no way to tell if a query failed on the database.
Wondering if we can fix this...
Fixes #172
The idea is to just create another response channel in the WebSocket that listens for errors. The
Send()method could then use that channel to return anerrorwhich would be the message returned from SurrealDB. Previously an error would never be returned bySend()leaving any failed queries to still wait for a response, preventing higher functions from returning.