build: Add tests for fetch using passing arguments #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The fetchUser passing pointer had another struct which was not necessarily needed - Removed PersonalInfo as it was not needed wrt the testcase
phughk
reviewed
Nov 30, 2023
- For negative test cases, test cases have been skipped for now. - For passing test cases, a helper method has been added to validate output
|
Maybe we can use |
Yep I was thinking of doing it in the follow up PR once this goes in. I am not sure how to use those methods, at the end of the README there were some examples but didn't really help. |
|
We should wait for the unmarshal improvements before merging this. Appreciate the patience and diligence 👍 |
add smartUnmarshal as helper in fetch tests
|
opened a PR to @sbshah97 's repo sbshah97#1 for unmarshal. |
phughk
reviewed
Dec 8, 2023
phughk
reviewed
Dec 8, 2023
remove validateFriends
Code Review comments suggestions added Co-authored-by: Przemyslaw Hugh Kaznowski <[email protected]>
…go into dev/sbshah97/db_test
|
@phughk could you review this again? |
|
Looks good. Thanks @sbshah97 !. Merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 5 different test cases to test the fetch functionality.
The remaining tests need to be changed once the functionality is fixed at the root source
Closes #40