Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved prettier (without formatting the repo) #578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattpocock
Copy link
Contributor

@mattpocock mattpocock commented Sep 6, 2024

Smaller version of #574

Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: 3989abe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mattpocock
Copy link
Contributor Author

This PR doesn't add formatting checks to the CI, since this would fail. This should be added when the formatting has been done.

@dmmulroy
Copy link
Contributor

dmmulroy commented Oct 9, 2024

This looks good to me - @m-shaka / @supermacro could we merge this?

@dmmulroy
Copy link
Contributor

dmmulroy commented Oct 9, 2024

@mattpocock could you generate a changeset file please 🙏 npx changeset

@mattpocock
Copy link
Contributor Author

@dmmulroy Since this isn't a user-facing change, I'm not sure a changeset makes sense

@mattpocock mattpocock mentioned this pull request Sep 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants