Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deind bump faustversion #172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

deind bump faustversion #172

wants to merge 2 commits into from

Conversation

LFSaw
Copy link
Member

@LFSaw LFSaw commented Nov 16, 2017

this picks up faust fixes by @carlocapocasa as discussed in #149 and applies them to JPverb and GreyHole.

@LFSaw LFSaw mentioned this pull request Nov 16, 2017
Open
telephon
telephon reviewed Nov 17, 2017
View reviewed changes
Copy link
Member

@telephon telephon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know the code better, @LFSaw, it's a lot to review. Is there anything you are uncertain about?

@LFSaw
Copy link
Member Author

LFSaw commented Nov 17, 2017

It is mainly compiling the sources and test if JPverb and GreyHole do something reasonable on scsynth and supernova.

@TauPan TauPan mentioned this pull request Dec 20, 2020
Closed
@dyfer
Copy link
Member

dyfer commented Jul 27, 2021 •
edited
Loading

Hello @LFSaw and @telephon
What is the status of this PR?

EDIT: it would be great to rebase this to resolve conflicts and make the CI run.

@telephon
Copy link
Member

@LFSaw could you do the rebase?

@capital-G
Copy link
Contributor

bump @LFSaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telephon telephon telephon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: plugins
Projects
SuperCollider development
Status: Waiting for review response
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LFSaw @dyfer @telephon @capital-G @capocasa