Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: erroneous create view in splinter.sql #108

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

soedirgo
Copy link
Member

@soedirgo soedirgo commented Jan 16, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

There's a create or replace view in the table bloat lint in splinter.sql. It wasn't omitted in compile.py because we're using create or replace view instead of create view

What is the new behavior?

create or replace view -> create view

@soedirgo soedirgo force-pushed the fix/create-view-in-splinter-sql branch from cfd07d7 to 33b6d57 Compare January 16, 2025 07:02
Copy link

@darora darora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a CI check that makes sure that the SQL we're creating is valid?

@soedirgo soedirgo merged commit ff2c6fc into main Jan 16, 2025
2 checks passed
@soedirgo soedirgo deleted the fix/create-view-in-splinter-sql branch January 16, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants