[WIP] use DefaultsKey.defaultValue for registering user defaults #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on macOS apps and rely on the effect of
register(defaults:)
a lot. It didn't bother me to register them manually, using the swifty keys in the dictionary like so:DefaultsKeys.myKey._key : 123
But now that the keys require a default value, I'd like to not duplicate using this.
Either make the
defaultValue
public for compatibility, I figured, or offer a convenient wrapper around theregister(defaults:)
method. This is a prototype for the latter.Is this a direction you want to go?
Usage:
This works thanks to a protocol that type-erases the internals of
DefaultsKey<T>
:It's not that convenient to have to use
DefaultsKeys.foo
to reference the key. But I think theDefaultsKeys
class can become a protocol instead, and the newDefaultsKeyable
can inherit from that, and then it should work to write.register(defaultsKeys: [ .foo, ... ])