-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] RBF mesh deformation #2240
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. I am looking forward to testing it :)
* \brief Get the type of mesh deformation method. | ||
* \return type of mesh deformation. | ||
*/ | ||
DEFORM_KIND GetDeform_Kind(void) const { return Deform_Kind; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEFORM_KIND GetDeform_Kind(void) const { return Deform_Kind; } | |
DEFORM_KIND GetDeform_Kind() const { return Deform_Kind; } |
@@ -6457,7 +6459,19 @@ void CConfig::SetOutput(SU2_COMPONENT val_software, unsigned short val_izone) { | |||
|
|||
if (val_software == SU2_COMPONENT::SU2_DEF) { | |||
cout << endl <<"---------------- Grid deformation parameters ( Zone " << iZone << " ) ----------------" << endl; | |||
cout << "Grid deformation using a linear elasticity method." << endl; | |||
cout << "Grid deformation using a "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cout << "Grid deformation using a "; | |
cout << "Grid deformation using "; |
/*! | ||
* \brief Destructor of the class. | ||
*/ | ||
~CLinearElasticity(void) override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~CLinearElasticity(void) override; | |
~CLinearElasticity() override; |
#include "../../include/toolboxes/CSymmetricMatrix.hpp" | ||
|
||
/*! | ||
* \class CLinearElasticity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* \class CLinearElasticity | |
* \class CRadialBasisFunctionInterpolation |
/*! | ||
* \brief Solving of the Radial Basis Function interpolation system, yielding the interpolation coefficients | ||
*/ | ||
void SolveRBF_System(void); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void SolveRBF_System(void); | |
void SolveRBF_System(); |
/*! | ||
* \brief Returns global index. | ||
*/ | ||
inline unsigned long GetIndex(void){return idx;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline unsigned long GetIndex(void){return idx;} | |
inline unsigned long GetIndex(){return idx;} |
/*! | ||
* \brief Returns vertex index. | ||
*/ | ||
inline unsigned long GetVertex(void){return vertex_idx;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline unsigned long GetVertex(void){return vertex_idx;} | |
inline unsigned long GetVertex(){return vertex_idx;} |
/*! | ||
* \brief Returns marker index. | ||
*/ | ||
inline unsigned short GetMarker(void){return marker_idx;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline unsigned short GetMarker(void){return marker_idx;} | |
inline unsigned short GetMarker(){return marker_idx;} |
controlNodes = &boundaryNodes; | ||
} | ||
|
||
CRadialBasisFunctionInterpolation::~CRadialBasisFunctionInterpolation(void) = default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRadialBasisFunctionInterpolation::~CRadialBasisFunctionInterpolation(void) = default; | |
CRadialBasisFunctionInterpolation::~CRadialBasisFunctionInterpolation() = default; |
break; | ||
case DEFORM_KIND::ELASTIC: | ||
VolumetricMovement = new CLinearElasticity(geometry, config); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see the freeing of the memory of those classes, when and where they were freed.
In case of internal boundaries that are allowed to move freely based on the deformation of moving boundaries, these options enable it to do so.
Requires some clean up work
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.