New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support for more than one digit after . for hsl colors in parseToRgb #657

Open

safareli wants to merge 1 commit into styled-components:main from safareli:patch-1

safareli commented Nov 27, 2024 •

edited

Loading

both S and L parts are <percentage> values see

The <percentage> data type consists of a <number> followed by the percentage sign (%). see

The syntax of <number> extends the syntax of <integer>. A fractional value is represented by a . followed by one or more decimal digits, and may be appended to an integer see

current regex only allowed for. 0 or 1 digit after .


          fix: support for more than one digit after . for hsl colors in parseT…

…oRgb

> both S and L parts are <percentage>  values see 
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/hsl#s


> The <percentage> data type consists of a <number> followed by the percentage sign (%). 
https://developer.mozilla.org/en-US/docs/Web/CSS/percentage


>The syntax of <number> extends the syntax of <integer>. A fractional value is represented by a . followed by one or more decimal digits, and may be appended to an integer
https://developer.mozilla.org/en-US/docs/Web/CSS/number

safareli requested a review from bhough as a code owner

November 27, 2024 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet