Lombok enhancement: Issue #12 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Synched my fork and resolved merge conflict with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains just the modifications for the
Orderclass. You'll see that the code is far more concise and it's easier to spot bugs.Would you please run your integration tests and see whether you have any issues? I also added
@JsonIgnoreProperties(ignoreUnknown=true), but feel free to remove that if you don't find that necessary.Additionally, I am removing
@JsonPropertyin most cases, but undo it if there were specific reasons for this. We typically use it to rename or distinguish a property (like using@JsonProperty("accountId")on a property that you locally callbrokerAccountIdto distinguish it from an account ID on your own application).Thanks,
Victor