Update build.gradle with namespace #1552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for RN 0.73 android builds
|
|
huextrat
approved these changes
Nov 2, 2023
charliecruzan-stripe
requested changes
Nov 2, 2023
| @@ -27,6 +27,11 @@ def getExtOrIntegerDefault(name) { | |||
| } | |||
|
|
|||
| android { | |||
| def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION | |||
| if (agpVersion.tokenize('.')[0].toInteger() >= 7) { | |||
There was a problem hiding this comment.
I think this could be an issue on < AGP 7.3, since that's when Google stated you can start using the namespace DSL property. Maybe it's better to just change 7 -> 8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for RN 0.73 android builds
Summary
Add namespace to android section of build.gradle, this is a requirement for Gradle 8 which is the default for RN 0.73+. It's wrapped in a version check for backwards compatability.
Motivation
Android won't build without it
Testing
Documentation
Select one: