Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more implementations to state flow. #8409

Merged
merged 3 commits into from May 6, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented May 2, 2024

Summary

I'm trying to remove collectAsState(null), these last few are tricky, and if I replace collectAsState(null) with collectAsState() after this change, it causes PaymentSheet to break. So I'm just getting more of the pre work done for now.

Copy link
Contributor

github-actions bot commented May 2, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │   3.9 MiB │   3.9 MiB │ -486 B │   8.6 MiB │   8.6 MiB │ +88 B 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │   0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  25.2 KiB │  25.2 KiB │   0 B 
      res │ 907.5 KiB │ 907.5 KiB │    0 B │   1.4 MiB │   1.4 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │   0 B 
    asset │   2.9 MiB │   2.9 MiB │   -1 B │   2.9 MiB │   2.9 MiB │  -1 B 
    other │   194 KiB │   194 KiB │   +6 B │ 423.6 KiB │ 423.6 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │  12.7 MiB │  12.7 MiB │ -481 B │  21.6 MiB │  21.6 MiB │ +87 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 43007 │ 43007 │  0 (+1 -1) 
   types │ 14756 │ 14756 │  0 (+0 -0) 
 classes │ 12461 │ 12461 │  0 (+0 -0) 
 methods │ 61021 │ 61021 │  0 (+2 -2) 
  fields │ 40303 │ 40304 │ +1 (+2 -1) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6028 │ 6028 │  0
APK
    compressed     │   uncompressed    │                               
──────────┬────────┼───────────┬───────┤                               
 size     │ diff   │ size      │ diff  │ path                          
──────────┼────────┼───────────┼───────┼───────────────────────────────
  3.9 MiB │ -486 B │   8.6 MiB │ +88 B │ ∆ classes.dex                 
 49.4 KiB │   +5 B │ 116.6 KiB │   0 B │ ∆ META-INF/MANIFEST.MF        
  1.2 KiB │   +2 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA           
  7.4 KiB │   -1 B │   7.2 KiB │  -1 B │ ∆ assets/dexopt/baseline.prof 
 52.7 KiB │   -1 B │ 116.7 KiB │   0 B │ ∆ META-INF/CERT.SF            
──────────┼────────┼───────────┼───────┼───────────────────────────────
    4 MiB │ -481 B │   8.8 MiB │ +87 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   43007 │ 43007 │ 0 (+1 -1) 
  
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:537db9b,r8-mode:full,version:8.3.37}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:4952457,r8-mode:full,version:8.3.37}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   61021 │ 61021 │ 0 (+2 -2) 
  
  + G6.k v(f, m0, m0, m0, q, k, int, int)
  + Q8.P <init>(f, f, h)
  
  - G6.k v(f, m0, m0, f, q, k, int, int)
  - Q8.P <init>(f, f, f)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40303 │ 40304 │ +1 (+2 -1) 
  
  + c7.e V: e
  + c7.i e: b
  
  - c7.i e: P

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/move-sf-impl branch 4 times, most recently from c8c9c88 to 30c0d0e Compare May 6, 2024 13:57
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review May 6, 2024 14:09
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners May 6, 2024 14:09
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) May 6, 2024 14:09
@jaynewstrom-stripe
Copy link
Collaborator Author

I need to rebase on #8411

@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) May 6, 2024 14:37
@jaynewstrom-stripe jaynewstrom-stripe merged commit de6f492 into master May 6, 2024
15 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/move-sf-impl branch May 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants