Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add institution icon to account picker #8389

Merged
merged 1 commit into from May 16, 2024

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented May 1, 2024

Summary

This pull request adds the institution icon to the account picker screen. This was presumably missed during the V3 work, as it’s present on Web and iOS.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented May 1, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ +1 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +1 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21686 │ 21686 │ 0 (+0 -0) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31447 │ 31447 │ 0 (+0 -0) 
  fields │ 18315 │ 18315 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
    272 B │ +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.1 KiB │ -1 B │   64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 30.5 KiB │ +1 B │ 65.3 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe marked this pull request as ready for review May 2, 2024 15:11
@tillh-stripe tillh-stripe requested review from a team as code owners May 2, 2024 15:11
@tillh-stripe tillh-stripe requested review from samer-stripe and carlosmuvi-stripe and removed request for samer-stripe May 2, 2024 15:11
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the icon also do shimmer loading while in loading state?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked into it, but it’s not very noticeable. I did restructure the loadingContent and loadedContent though to fix an issue where the institution icon was flashing.

samer-stripe
samer-stripe previously approved these changes May 6, 2024
@tillh-stripe tillh-stripe force-pushed the tillh/add-institution-icon-in-account-picker branch from 75c945d to 2cb49ed Compare May 16, 2024 16:43
This also combines the `loadingContent` and `loadedContent` methods to fix an issue where the institution icon was flashing.
@tillh-stripe tillh-stripe force-pushed the tillh/add-institution-icon-in-account-picker branch from 2cb49ed to 8374427 Compare May 16, 2024 17:04
@tillh-stripe tillh-stripe merged commit 0c5a458 into master May 16, 2024
12 checks passed
@tillh-stripe tillh-stripe deleted the tillh/add-institution-icon-in-account-picker branch May 16, 2024 20:38
@tillh-stripe tillh-stripe mentioned this pull request May 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants