New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add institution icon to account picker #8389
Add institution icon to account picker #8389
Conversation
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
...ava/com/stripe/android/financialconnections/features/accountpicker/AccountPickerViewModel.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the icon also do shimmer loading while in loading state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked into it, but it’s not very noticeable. I did restructure the loadingContent
and loadedContent
though to fix an issue where the institution icon was flashing.
2cb49ed
75c945d
to
2cb49ed
Compare
This also combines the `loadingContent` and `loadedContent` methods to fix an issue where the institution icon was flashing.
2cb49ed
to
8374427
Compare
Summary
This pull request adds the institution icon to the account picker screen. This was presumably missed during the V3 work, as it’s present on Web and iOS.
Motivation
Testing
Screenshots
Changelog