Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist selected account IDs to SavedStateHandle #8358

Merged
merged 3 commits into from May 6, 2024

Conversation

tillh-stripe
Copy link
Collaborator

Summary

This pull request persists selected account IDs on the device to improve our process death handling.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recordings

Before

broken-process-death-handling.webm

After

fixed-process-death-handling.webm

Changelog

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ +1 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +1 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21683 │ 21683 │ 0 (+0 -0) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31447 │ 31447 │ 0 (+0 -0) 
  fields │ 18320 │ 18320 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
    272 B │ +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.1 KiB │ +1 B │   64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.8 KiB │ -1 B │ 63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 55.2 KiB │ +1 B │  128 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe marked this pull request as ready for review April 30, 2024 14:20
@tillh-stripe tillh-stripe requested review from a team as code owners April 30, 2024 14:20
@tillh-stripe tillh-stripe requested review from samer-stripe and carlosmuvi-stripe and removed request for samer-stripe April 30, 2024 14:20
@tillh-stripe tillh-stripe force-pushed the tillh/fc-persist-selected-account-ids branch from 324a05f to 52bb6bb Compare April 30, 2024 14:40
@tillh-stripe tillh-stripe merged commit a9f7bfd into master May 6, 2024
12 checks passed
@tillh-stripe tillh-stripe deleted the tillh/fc-persist-selected-account-ids branch May 6, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants