This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[cleanup] Create only one instance of KafkaTopicLookupService #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
force-pushed
the
impl/single-kafkaTopicLookupService
branch
from
3a1a570
to
b9ca312
Compare
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
=========================================
Coverage 15.75% 15.76%
- Complexity 612 613 +1
=========================================
Files 164 164
Lines 12262 12268 +6
Branches 1124 1124
=========================================
+ Hits 1932 1934 +2
- Misses 10171 10176 +5
+ Partials 159 158 -1
|
eolivelli
force-pushed
the
impl/single-kafkaTopicLookupService
branch
from
b9ca312
to
62ebec6
Compare
eolivelli
requested review from
BewareMyPower and
Demogorgon314
as code owners
|
The failure " KafkaMessageOrderKafkaTest>KafkaMessageOrderTestBase.testKafkaProduceMessageOrder" is not related to this patch. I am working on that test currently, but it is a separate topic |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is stacked on top of #1720
Motivation
This patch prepares some changes for transaction recovery
Modifications
Create only one instance of KafkaTopicLookupService
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)