-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring the view extensions docs on par #3711
base: main
Are you sure you want to change the base?
Bring the view extensions docs on par #3711
Conversation
Reviewer's Guide by SourceryThis PR updates and standardizes the documentation for extending view classes across all integration modules. The changes focus on improving type hints, adding missing extension methods, and ensuring consistency in method signatures and examples. Updated class diagram for GraphQLController extensionsclassDiagram
class GraphQLController {
+async process_result(request: Request, result: ExecutionResult) GraphQLHTTPResponse
+decode_json(data: Union[str, bytes]) object
+encode_json(data: object) str
+async render_graphql_ide(request: Request) Response
}
class MyGraphQLController {
+async process_result(request: Request, result: ExecutionResult) GraphQLHTTPResponse
+decode_json(data: Union[str, bytes]) object
+encode_json(data: object) str
}
GraphQLController <|-- MyGraphQLController
Updated class diagram for GraphQLView extensionsclassDiagram
class GraphQLView {
+get_context(request: Request, response: Response) Context
+get_root_value(request: Request) Optional[RootValue]
+process_result(request: Request, result: ExecutionResult) GraphQLHTTPResponse
+decode_json(data: Union[str, bytes]) object
+encode_json(data: object) str
+render_graphql_ide(request: Request) Response
}
class MyGraphQLView {
+get_context(request: Request, response: Response) Context
+get_root_value(request: Request) Optional[RootValue]
+process_result(request: Request, result: ExecutionResult) GraphQLHTTPResponse
+decode_json(data: Union[str, bytes]) object
+encode_json(data: object) str
}
GraphQLView <|-- MyGraphQLView
Updated class diagram for GraphQLRouter extensionsclassDiagram
class GraphQLRouter {
+async process_result(request: Request, result: ExecutionResult) GraphQLHTTPResponse
+decode_json(data: Union[str, bytes]) object
+encode_json(data: object) str
+async render_graphql_ide(request: Request) HTMLResponse
}
class MyGraphQLRouter {
+async process_result(request: Request, result: ExecutionResult) GraphQLHTTPResponse
+decode_json(data: Union[str, bytes]) object
+encode_json(data: object) str
}
GraphQLRouter <|-- MyGraphQLRouter
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DoctorJohn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
80ef416
to
b0f74c6
Compare
Description
This PR updates the "Extending the view" sections of all integrations.
I made sure all overrideable methods of the base view are documented with the correct types and that all the examples include all required imports to run them.
(The only exception are the Channels docs which I only updated partially. I want to combine the HTTP and WS consumers there first, otherwise the docs will include everything twice).
Types of Changes
Summary by Sourcery
Documentation: