-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Failing to pass a value to the type_params parameter of typing._eval_type" #3692
Conversation
Reviewer's Guide by SourceryThis PR fixes a bug in the type evaluation functionality by explicitly passing Sequence diagram for type evaluation with _eval_typesequenceDiagram
participant eval_type
participant _eval_type
eval_type->>_eval_type: Call _eval_type(type_, globalns, localns, type_params=None)
_eval_type-->>eval_type: Return evaluated type
note right of eval_type: Explicitly passing None to type_params
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patrick91 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thanks for adding the Here's a preview of the changelog: This release fixes the following deprecation warning:
This was only trigger in Python 3.13 and above. Here's the tweet text:
|
6b342b2
to
a5c38d9
Compare
aa95bba
to
e03b32c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3692 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 502 502
Lines 33568 33571 +3
Branches 5634 5635 +1
=======================================
+ Hits 32565 32568 +3
Misses 796 796
Partials 207 207 |
CodSpeed Performance ReportMerging #3692 will not alter performanceComparing Summary
|
Closes #3690
Summary by Sourcery
Bug Fixes: