Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide execution context as an argument to schema extensions #3640

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nrbnlulu
Copy link
Member

@nrbnlulu nrbnlulu commented Sep 23, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

fix #3571

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nrbnlulu nrbnlulu changed the title fc Provide execution context as an argument to schema extensions Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 93.67089% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.25%. Comparing base (56172dc) to head (1fbdc54).

❗ There is a different number of reports uploaded between BASE (56172dc) and HEAD (1fbdc54). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (56172dc) HEAD (1fbdc54)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3640       +/-   ##
===========================================
- Coverage   97.01%   64.25%   -32.77%     
===========================================
  Files         503      498        -5     
  Lines       33458    32181     -1277     
  Branches     5618     1654     -3964     
===========================================
- Hits        32460    20677    -11783     
- Misses        792    11195    +10403     
- Partials      206      309      +103     

Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #3640 will improve performances by ×6.2

Comparing nrbnlulu:provide-execution-context-to-each-schema-extension-hook (1fbdc54) with main (56172dc)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main nrbnlulu:provide-execution-context-to-each-schema-extension-hook Change
test_execute_with_many_fields_and_directives 41.9 ms 6.8 ms ×6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions execution context can easily overlap between parallel executions.
1 participant