-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bump ruff's minimum python version to 3.8 and remove remaining python 3.7 code #2995
Conversation
…ing python 3.7 code
strawberry/utils/cached_property.py
Outdated
@@ -1,11 +1,6 @@ | |||
import sys | |||
from functools import cached_property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrick91 This module is not needed anymore. Should we change all callsites to import from functools
directly and remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Thanks for adding the Here's a preview of the changelog: This release updates Strawberry's codebase to use new features in Python 3.8. Here's the preview release card for twitter: Here's the tweet text:
|
CodSpeed Performance ReportMerging #2995 will not alter performanceComparing Summary
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
==========================================
+ Coverage 96.47% 96.50% +0.03%
==========================================
Files 469 468 -1
Lines 29144 29109 -35
Branches 3587 3582 -5
==========================================
- Hits 28116 28091 -25
+ Misses 840 835 -5
+ Partials 188 183 -5 |
@patrick91 the tests are fine other than the lack of a Do you think we need to make a release for this change? It is mostly internal refactoring stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've added a release file, and removed backports.cached-property
from the deps 😊
Awesome! Forgot to do that :) |
…ing python 3.7 code (strawberry-graphql#2995) Co-authored-by: Patrick Arminio <[email protected]>
No description provided.