Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump ruff's minimum python version to 3.8 and remove remaining python 3.7 code #2995

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

bellini666
Copy link
Member

No description provided.

@bellini666 bellini666 self-assigned this Jul 31, 2023
@@ -1,11 +1,6 @@
import sys
from functools import cached_property
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrick91 This module is not needed anymore. Should we change all callsites to import from functools directly and remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@botberry
Copy link
Member

botberry commented Jul 31, 2023

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release updates Strawberry's codebase to use new features in Python 3.8.
It also removes backports.cached-property from our dependencies, as we can
now rely on the standard library's functools.cached_property.


Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to Thiago Bellini Ribeiro for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 31, 2023

CodSpeed Performance Report

Merging #2995 will not alter performance

Comparing bellini666:3_7 (5b330c7) with main (306e3db)

Summary

✅ 12 untouched benchmarks

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2995 (5b330c7) into main (306e3db) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2995      +/-   ##
==========================================
+ Coverage   96.47%   96.50%   +0.03%     
==========================================
  Files         469      468       -1     
  Lines       29144    29109      -35     
  Branches     3587     3582       -5     
==========================================
- Hits        28116    28091      -25     
+ Misses        840      835       -5     
+ Partials      188      183       -5     

@bellini666
Copy link
Member Author

@patrick91 the tests are fine other than the lack of a RELEASE.md file.

Do you think we need to make a release for this change? It is mostly internal refactoring stuff

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've added a release file, and removed backports.cached-property from the deps 😊

@bellini666
Copy link
Member Author

Looks good, I've added a release file, and removed backports.cached-property from the deps blush

Awesome! Forgot to do that :)

@bellini666 bellini666 merged commit 9444c30 into strawberry-graphql:main Aug 8, 2023
49 of 52 checks passed
@bellini666 bellini666 deleted the 3_7 branch August 8, 2023 21:52
etripier pushed a commit to Greenbax/strawberry that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants