Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added failing test #657

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NT-Timm
Copy link

@NT-Timm NT-Timm commented Nov 14, 2024

Had to add the types outside of the function and rename them for strawberry.lazy.
The DjangoOptimizerExtension gives an error on nested pagination.

Summary by Sourcery

Tests:

  • Add a failing test for nested pagination using DjangoOptimizerExtension.

Copy link
Contributor

sourcery-ai bot commented Nov 14, 2024

Reviewer's Guide by Sourcery

The changes modify a test file to address issues with nested pagination and type definitions in a Strawberry Django GraphQL implementation. The main modifications involve moving type definitions outside the test function, renaming them, and updating type annotations to use strawberry.lazy for handling circular dependencies.

Updated class diagram for test types in test_paginated_type.py

classDiagram
    class FruitTest {
        int id
        str name
    }
    class ColorTest {
        int id
        str name
        OffsetPaginated~FruitTest~ fruits
    }
    class Query {
        OffsetPaginated~ColorTest~ colors
    }
    FruitTest --> ColorTest : used in
    Query --> ColorTest : paginated colors
    note for ColorTest "Uses strawberry.lazy to handle circular dependencies"
    note for Query "Includes DjangoOptimizerExtension in schema"
Loading

File-Level Changes

Change Details Files
Restructured type definitions and moved them outside the test function
  • Moved Fruit and Color type definitions outside the test function
  • Renamed type classes to FruitTest and ColorTest
  • Updated type references in the Query class to use the new type names
tests/test_paginated_type.py
Updated type annotations to handle circular dependencies
  • Added import for Annotated from typing
  • Modified fruits field type annotation to use Annotated with strawberry.lazy
  • Added explicit path reference in strawberry.lazy for type resolution
tests/test_paginated_type.py
Added Django Optimizer Extension to the schema
  • Imported DjangoOptimizerExtension
  • Added DjangoOptimizerExtension to schema initialization
tests/test_paginated_type.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NT-Timm - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title and description could be more descriptive of the actual changes. Consider updating them to reflect that this PR fixes nested pagination issues by restructuring types and adding DjangoOptimizerExtension.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant