-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added failing test #657
base: main
Are you sure you want to change the base?
added failing test #657
Conversation
Reviewer's Guide by SourceryThe changes modify a test file to address issues with nested pagination and type definitions in a Strawberry Django GraphQL implementation. The main modifications involve moving type definitions outside the test function, renaming them, and updating type annotations to use strawberry.lazy for handling circular dependencies. Updated class diagram for test types in test_paginated_type.pyclassDiagram
class FruitTest {
int id
str name
}
class ColorTest {
int id
str name
OffsetPaginated~FruitTest~ fruits
}
class Query {
OffsetPaginated~ColorTest~ colors
}
FruitTest --> ColorTest : used in
Query --> ColorTest : paginated colors
note for ColorTest "Uses strawberry.lazy to handle circular dependencies"
note for Query "Includes DjangoOptimizerExtension in schema"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NT-Timm - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR title and description could be more descriptive of the actual changes. Consider updating them to reflect that this PR fixes nested pagination issues by restructuring types and adding DjangoOptimizerExtension.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
for more information, see https://pre-commit.ci
Had to add the types outside of the function and rename them for strawberry.lazy.
The DjangoOptimizerExtension gives an error on nested pagination.
Summary by Sourcery
Tests: