This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
[3.0.8.0] Fast Rewind #4082
Open
[3.0.8.0] Fast Rewind #4082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (int i = 0; i < addChangesTimes; i++) | ||
| var random = new Random(); | ||
|
|
||
| while (currentHeight > 1) |
There was a problem hiding this comment.
Is this going to loop until random returns a 0?
There was a problem hiding this comment.
Yes we keep rewinding between >0% and 100% of the remaining blocks until there is nothing left to rewind.
currentHeight = random.Next(currentHeight - 1) + 1; will always reduce currentHeight.
| @@ -75,8 +75,7 @@ public uint256 NewBlock() | |||
|
|
|||
| public uint256 Rewind() | |||
| { | |||
| this.hash = this.coinView.Rewind(); | |||
| this.blockHeight--; | |||
| this.hash = this.coinView.Rewind(--this.blockHeight); | |||
There was a problem hiding this comment.
Is this correct? This is different functionality to previously. This will pass blockHeight-1 to Rewind.
There was a problem hiding this comment.
Yes. It's the target height. Previously we implicitly passed blockHeight-1 to Rewind. Now its explicit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stratisplatformuk.visualstudio.com/StratisBitcoinFullNode/_workitems/edit/3338/