New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update styled-components to 6 & update DS to 2.0.0-beta.3 #20260
Conversation
09f63d1
to
94314e1
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f06119b
to
dc1f8d4
Compare
1e6d104
to
33dab7a
Compare
9ebfd37
to
42cd99f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just little things.
The only big thing is my concern about requiring everything to be wrapped in Fields with an explicit label, it feels like the increased verbosity will lead to more mistakes and a steeper learning curve. But this isn't my scope so I won't object too strongly 😆
...ges/core/admin/admin/src/pages/Settings/pages/Webhooks/components/tests/WebhookForm.test.tsx
Show resolved
Hide resolved
...tent-manager/admin/src/pages/EditView/components/FormInputs/DynamicZone/DynamicComponent.tsx
Outdated
Show resolved
Hide resolved
...s/core/content-manager/admin/src/pages/EditView/components/FormInputs/Wysiwyg/WysiwygNav.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a ton of unused imports in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we can ignore that, @madhurisandbhor is working on re-implementing it all in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a small handful of components that still use ariaLabel
instead of aria-label
, is that intentional? It feels inconsistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on the context but most likely yes, we typically pass prop as camelCase and convert to kebab-case. But also, we also have bad naming on some props...
packages/core/content-type-builder/admin/src/components/CustomRadioGroup/Styles.tsx
Outdated
Show resolved
Hide resolved
...ages/core/upload/admin/src/components/AssetDialog/BrowseStep/PaginationFooter/components.jsx
Outdated
Show resolved
Hide resolved
packages/core/upload/admin/src/components/UploadAssetDialog/tests/UploadAssetDialog.test.jsx
Show resolved
Hide resolved
Maybe, in an ideal world we'd all just use the form input renderer and we just have one set of fields to maintain, then there is no learning curve. |
76bbbea
to
c35d279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make this a bug in JIRA |
What does it do?
Related issue(s)/PR(s)