New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(main-nav): Main nav refactoring, refactor the main nav container and all the links and user profile #20245
Conversation
It is still in draft because I need to refine some stuff and add tests but the ui is implemented so I need some comments just to understand if the main work is ok or not, thanks |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not QAd but code looks good ✅ lets squash merge this when we do merge though, not sure we need all these commits!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works great!
✅ matches the designs
✅ only shows menu items available to the logged in user
✅ shows the EE features with a lock when on CE (though I couldn't find that in figma)
✅ able to access profile and logout
✅ the middle section is scrollable when the viewport is too short
✅ light and dark theme display as expected
Hey @simotae14 congrats, that's great! I just reported minor issues in the Blitz document :) |
Feedback noted @derrickmehaffy, thanks 👍 |
What does it do?
It shows the new main nav. Now all the links are shown with just the icon, the divider between the links are removed and we are using new components in the admin to render the Main nav
Why is it needed?
In the refactoring of the Main Nav we want a new narrow nav to add more space for the important content, also we removed the Dividers (hr elements) between the links
How to test it?
Just check the new main nav in the different themes, using a CE license and EE license, all the states of the links (active, hover) and the Profile button
You can find all the info and link to the figma file in the Jira ticket
Related issue(s)/PR(s)
CS-758 and CS-766