Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: refactor Dialog component to use radix primitive #1727

Merged
merged 2 commits into from
May 20, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • refactors Dialog to use the radix-ui primitive
  • exports helpful hooks like useMeasure, useControllableState, useId & useIsomorphicLayoutEffect

Related issue(s)/PR(s)

  • resolves DX-1293

@joshuaellis joshuaellis added pr: enhancement This PR adds or updates some part of the codebase or features source: design-system relates to design-system package labels May 20, 2024
@joshuaellis joshuaellis self-assigned this May 20, 2024
Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: 1497a46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/icons Major
@strapi/ui-primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 0:06am
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 0:06am
design-system-website 🛑 Canceled (Inspect) May 20, 2024 0:06am

Copy link
Contributor

github-actions bot commented May 20, 2024

Size Change: +1.12 kB (+0.39%)

Total Size: 288 kB

Filename Size Change
packages/design-system/dist/index.js 94.4 kB +592 B (+0.63%)
packages/design-system/dist/index.mjs 93.2 kB +525 B (+0.57%)
ℹ️ View Unchanged
Filename Size
packages/icons/dist/index.js 22.1 kB
packages/icons/dist/index.mjs 21.7 kB
packages/icons/dist/symbols-index.js 11.9 kB
packages/icons/dist/symbols-index.mjs 11.8 kB
packages/primitives/dist/index.js 16.7 kB
packages/primitives/dist/index.mjs 16.3 kB

compressed-size-action

@joshuaellis joshuaellis merged commit 490835e into releases/2.0.0 May 20, 2024
11 of 12 checks passed
@joshuaellis joshuaellis deleted the feat/dialog branch May 20, 2024 13:44
joshuaellis added a commit that referenced this pull request Jun 4, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to releases/2.0.0,
this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`releases/2.0.0` is currently in **pre mode** so this branch has
prereleases rather than normal releases. If you want to exit
prereleases, run `changeset pre exit` on `releases/2.0.0`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @strapi/[email protected]

### Major Changes

- [#1725](#1725)
[`a292dc3`](a292dc3)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
chore!: refactor Radio to use radix primitive

- [#1725](#1725)
[`6040949`](6040949)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
chore!: refactor ModalLayout to Modal and use radix-ui primitives

- [#1727](#1727)
[`490835e`](490835e)
Thanks [@joshuaellis](https://github.com/joshuaellis)! - chore!:
refactor Dialog component to use radix primitive

- [#1725](#1725)
[`5ff487b`](5ff487b)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
chore!: refactor Avatar component to use radix primitive

- [#1725](#1725)
[`569133b`](569133b)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
chore!: refactor Checkbox to use radix primitive

- [#1725](#1725)
[`6040949`](6040949)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
chore!: refactor Grid to be composite component

- [#1725](#1725)
[`43d440e`](43d440e)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
chore!: refactor Tabs component to use radix primitive

- [#1725](#1725)
[`a843b4c`](a843b4c)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
chore!: refactor Popover to use radix-ui primitive

### Minor Changes

- [#1727](#1727)
[`490835e`](490835e)
Thanks [@joshuaellis](https://github.com/joshuaellis)! - feat: export
useMeasure, useControllableState, useId & useIsomorphicLayoutEffect

- [#1725](#1725)
[`f328dee`](f328dee)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
feat: add ScrollArea component

- [#1725](#1725)
[`a5c4031`](a5c4031)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
feat: add motion properties to theme as well as transitions

### Patch Changes

- [#1725](#1725)
[`01ff7ca`](01ff7ca)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
fix(design-system): edit Divider accessibility design

- [#1725](#1725)
[`6040949`](6040949)
Thanks [@github-actions](https://github.com/apps/github-actions)! -
fix(design-system): time-picker icon was too small

-   Updated dependencies \[]:
    -   @strapi/[email protected]

## @strapi/[email protected]

### Minor Changes

- [#1728](#1728)
[`f34ca77`](f34ca77)
Thanks [@simotae14](https://github.com/simotae14)! - add lightning icon

## @strapi/[email protected]
@joshuaellis joshuaellis linked an issue Jun 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Dialog overflows unscrollable
1 participant