Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing locale props #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devchanki
Copy link

@devchanki devchanki commented Jan 3, 2025

add missing props in LocaleSwitcher

What does it do?

This change adds the missing props to the LocaleSwitcher component.
Though it's a simple fix, I plan to continue exploring this project by creating various apps and addressing bugs along the way.

<LocaleSwitcher currentLocale={locale} />

Why is it needed?

The missing props are required by the type definitions, and their absence causes type-checking errors during the build process.

How to test it?

I successfully built the app without errors.

image
Additionally, I tested it in the development environment using yarn dev.

Some additional things to check:

This is a minor change, and while I did not conduct a thorough verification, I confirmed like UUID generation as part of the review.

  • Strapi project uuid is "LAUNCHPAD". strapi/packages.json.
  • If you updated content, make sure to create a new export in the strapi/data folder and update the strapi/packages.json seed command if necessary.
  • Strapi version is the latest possible.

Related issue(s)/PR(s)

I created and resolved this issue.
#27

add missing props in LocaleSwitcher
@devchanki devchanki marked this pull request as draft January 3, 2025 16:55
@devchanki devchanki marked this pull request as ready for review January 3, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant