-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract email templates into individual classes #3234
base: v3.4
Are you sure you want to change the base?
Conversation
Create email template class
* Fix for sitename variable
* Pass level id to cancel function from edit member page
*Add missing variables for backwards compat
* Add Change Membership Classes ( admin and member )
…celed-auto-renewals * Add canceled autorenewal template / classes for member and admin
…and its references
…sent in the abstract Email Template Class.
* Compare param user with order user and use the one from the order if they don't match.
…t/add-billing-failure-class
…ling-failure-class Add payment failure classes
…t/add-billing-info-class
…ckout-check * Add checkout templates
…t/add-credit-card-expiring-class
…dit-card-expiring-class * Add credit card expiring email class
…t/membership-expired
…t/membership-expiring
…hip-expired *add expired membership email class
…t/membership-expiring
…hip-expiring [ENHANCEMENT] * Add Membership expiring email class
…t/payment-template-classes
…-template-classes * Add Payment Email Classes
…t/add-refund-email-class
…und-email-class * Add refund email classes
Fixing incorrect variable usage and subject line that was not meant to change
classes/email-templates/class-pmpro-email-template-billing-admin.php
Outdated
Show resolved
Hide resolved
In looking at this deeper now it seems dev does have "duplicate" variables like login_link, orders_link, and levels_link. They seem to be just populated in the PHP, not shown as "variables" you can use. Probably in an effort to reduce confusion. Maybe we had to keep these because of old merged in Add On, like CONPD? IF we keep both the _link and _url versions just to make sure the populate, let's only show the _url versions, which seem to be what we showed in our variable reference from. |
All Submissions:
Changes proposed in this Pull Request:
Creating an abstract class for email templates will allow us to avoid duplicate code that is common across every email template. Separating each template into a separate class will then make it easier to modify existing emails and add additional email templates down the road.
Other information:
Changelog entry