Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set first name to the users first name or display name depending… #29

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kimcoleman
Copy link
Member

… on what we have available

All Submissions:

Changes proposed in this Pull Request:

We should only set the subscriber's "First Name" to their user First Name (if available). Since a name is required in the API, we will fall back to display_name since that is always set on a WP user.

Closes Issue: #28

Changelog entry

  • BUG FIX/ENHANCEMENT: Updated logic for $user_name to use the first name if available, otherwise falling back to the display name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant