Add option to only run play or smoke tests #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielperales
commented
Feb 4, 2023
| @@ -80,6 +80,7 @@ export const transformPlaywright = (src: string, filename: string) => { | |||
| insertTestIfEmpty: true, | |||
| clearBody: true, | |||
| makeTitle: makeTitleFactory(filename), | |||
| onlyType: process.env.ONLY_TYPE as StorybookTestType, | |||
There was a problem hiding this comment.
This is the only thing I'm not sure... 🤔
|
Hey there, thanks for your contribution (as followup from @josephnle's one). Even though it's a good idea, I was wondering if we could fix this behavior differently, and just use the native test filtering functionality from jest (testNamePattern). Please check this comment for context: #281 (comment) |
|
Any updates on this @gabrielperales ? Would be a very nice feature! |
|
@rebeccadavidsson I'm no longer working with storybook tests, so I stopped working on this. |
|
Hey there! I'll be closing this PR because this functionality is now available via test filtering with tags. for running only play tests for running only smoke tests Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a rebase over @josephnle PR to update his code.