-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Prerelease 8.5.0-beta.8 #30156
Conversation
- Add `configDir` option to example configs - Move coverage exclusion config under Set up heading - Add `**/.storybook/**`
Docs: A11y minor fixes
Docs: Fixes found during 8.5 QA
…hadow-on-scrollbar UI: Fix overlapping shadow of testing module on scrollbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
framework: '@storybook/your-framework', | ||
stories: ['../src/**/*.mdx', '../stories/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
async webpackFinal(config) { | ||
storybookBaseConfig.module?.rules?.push({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: storybookBaseConfig is undefined - should be using config parameter instead
framework: '@storybook/your-framework', | ||
stories: ['../src/**/*.mdx', '../stories/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
async webpackFinal(config) { | ||
storybookBaseConfig.module?.rules?.push({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: storybookBaseConfig is undefined - should be using config parameter instead
async viteFinal(config) { | ||
return { | ||
...config, | ||
plugins: [...(config.plugins ?? []), graphql()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: graphql() function is used but not imported or defined
bb315b3
to
83a5489
Compare
83a5489
to
587aeeb
Compare
…only Maintenance: Move `@types/node` to `devDeps` consistently
587aeeb
to
ec4108a
Compare
…ite-conf Automigrations: Skip vite config file migration for react native web
ec4108a
to
d215275
Compare
…or-addon-panel-calculation Manager: Optimize getPanels function with memoization
d215275
to
a5ffbc8
Compare
Docs: Rename `a11ytest` tag to `a11y-test`
a5ffbc8
to
057c4ff
Compare
Vite: Fix wrong import paths when configDir is not in project root
057c4ff
to
2607e0b
Compare
…imultaneously React: Force act running always in sequence
2607e0b
to
13391ac
Compare
…de-modules RNW-Vite: Fix reanimated support with babel plugin for node_modules
13391ac
to
ca42774
Compare
This is an automated pull request that bumps the version from
8.5.0-beta.7
to8.5.0-beta.8
.Once this pull request is merged, it will trigger a new release of version
8.5.0-beta.8
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:@types/node
todevDeps
consistently #30163a11ytest
tag toa11y-test
#30198acb6a30a1f91d5ac6ef1c9a5412864b2b768583c
If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-beta.8
@types/node
todevDeps
consistently - #30163, thanks @ndelangen!